Add BLS signature support #1659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hashes, keys, signing, verification moved to 'radix-engine-common'. In 'transaction' above primitives are wrapped with RE specifics such as: - IntentSignature, - NotarySignature - etc.
This is to make them visible for scrypto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for BLS signatures.
It also implements
CryptoUtilsnative package, which allows to perform some cryptographic operations natively.Details
BLS details:
CryptoUtilsfunctions:keccak_hash()- generate Keccak-256 hash of the given messageATM it Keccak-256 is faked by Blake2b, it shall be changed soon
bls_verify()- do the given BLS signature verification of the given message hash using given public keyIn order to get it working I had to move cryptographic primitives (PrivateKey, Signature definitions) from
transactiontoradix-engine-common. What is left intransactionare the Radix Engine cryptographics, eg.IntentSignatureV1,NotarySignatureV1.TODO: Costing
Testing
CryptoUtilspackage using test_runnerCryptoUtilspackage usingCryptoScryptotest blueprintUpdate Recommendations
For dApp Developers
CryptoUtilspackage might be used to delegate cryptographic operations to the native layer.NOTE!
CryptoUtilspackage must be published before (it is not being published during bootstrap as other native packages)